Phase 3: Budget and sharing API

- Add BudgetsController: list (owner + shared), create, get, rename, delete
- Add BudgetAuthorizationService: Owner / Edit / View / None access levels
- Add SharesController: list, add (resolves KnownUser immediately), update permission, revoke
- Register BudgetAuthorizationService as scoped service
- Add BudgetDto, ShareDto, and associated request DTOs

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Spencer Twaddle
2026-04-25 07:55:07 -05:00
parent ae21da6a81
commit 963e511287
6 changed files with 220 additions and 0 deletions
@@ -0,0 +1,79 @@
using Budget.Api.Data;
using Budget.Api.DTOs;
using Budget.Api.Models;
using Budget.Api.Services;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Mvc;
using Microsoft.EntityFrameworkCore;
namespace Budget.Api.Controllers;
[ApiController]
[Route("api/[controller]")]
[Authorize]
public class BudgetsController(AppDbContext db, BudgetAuthorizationService authz) : ControllerBase
{
private string UserId => User.FindFirst("sub")!.Value;
[HttpGet]
public async Task<IActionResult> List()
{
var userId = UserId;
var budgets = await db.Budgets
.Where(b => b.OwnerUserId == userId ||
b.Shares.Any(s => s.SharedWithUserId == userId && !s.IsPending))
.Select(b => new BudgetDto(b.Id, b.Name, b.OwnerUserId, b.EffectiveTaxRate, b.CreatedAt, b.UpdatedAt))
.ToListAsync();
return Ok(budgets);
}
[HttpPost]
public async Task<IActionResult> Create([FromBody] CreateBudgetRequest req)
{
var budget = new Models.Budget
{
Id = Guid.NewGuid(),
Name = req.Name,
OwnerUserId = UserId,
CreatedAt = DateTimeOffset.UtcNow,
UpdatedAt = DateTimeOffset.UtcNow,
};
db.Budgets.Add(budget);
await db.SaveChangesAsync();
return CreatedAtAction(nameof(Get), new { id = budget.Id },
new BudgetDto(budget.Id, budget.Name, budget.OwnerUserId, budget.EffectiveTaxRate, budget.CreatedAt, budget.UpdatedAt));
}
[HttpGet("{id:guid}")]
public async Task<IActionResult> Get(Guid id)
{
if (!await authz.CanReadAsync(id, UserId)) return Forbid();
var b = await db.Budgets.FindAsync(id);
if (b is null) return NotFound();
return Ok(new BudgetDto(b.Id, b.Name, b.OwnerUserId, b.EffectiveTaxRate, b.CreatedAt, b.UpdatedAt));
}
[HttpPut("{id:guid}")]
public async Task<IActionResult> Update(Guid id, [FromBody] UpdateBudgetRequest req)
{
if (!await authz.CanWriteAsync(id, UserId)) return Forbid();
var b = await db.Budgets.FindAsync(id);
if (b is null) return NotFound();
b.Name = req.Name;
b.UpdatedAt = DateTimeOffset.UtcNow;
await db.SaveChangesAsync();
return Ok(new BudgetDto(b.Id, b.Name, b.OwnerUserId, b.EffectiveTaxRate, b.CreatedAt, b.UpdatedAt));
}
[HttpDelete("{id:guid}")]
public async Task<IActionResult> Delete(Guid id)
{
if (!await authz.IsOwnerAsync(id, UserId)) return Forbid();
var b = await db.Budgets.FindAsync(id);
if (b is null) return NotFound();
db.Budgets.Remove(b);
await db.SaveChangesAsync();
return NoContent();
}
}
@@ -0,0 +1,75 @@
using Budget.Api.Data;
using Budget.Api.DTOs;
using Budget.Api.Models;
using Budget.Api.Services;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Mvc;
using Microsoft.EntityFrameworkCore;
namespace Budget.Api.Controllers;
[ApiController]
[Route("api/budgets/{budgetId:guid}/shares")]
[Authorize]
public class SharesController(AppDbContext db, BudgetAuthorizationService authz) : ControllerBase
{
private string UserId => User.FindFirst("sub")!.Value;
[HttpGet]
public async Task<IActionResult> List(Guid budgetId)
{
if (!await authz.CanReadAsync(budgetId, UserId)) return Forbid();
var shares = await db.BudgetShares
.Where(s => s.BudgetId == budgetId)
.Select(s => new ShareDto(s.Id, s.SharedWithUserId, s.SharedWithEmail, s.Permission, s.IsPending, s.CreatedAt))
.ToListAsync();
return Ok(shares);
}
[HttpPost]
public async Task<IActionResult> Add(Guid budgetId, [FromBody] CreateShareRequest req)
{
if (!await authz.IsOwnerAsync(budgetId, UserId)) return Forbid();
var existing = await db.BudgetShares
.FirstOrDefaultAsync(s => s.BudgetId == budgetId && s.SharedWithEmail == req.Email);
if (existing is not null) return Conflict("A share for that email already exists.");
var knownUser = await db.KnownUsers.FirstOrDefaultAsync(u => u.Email == req.Email);
var share = new BudgetShare
{
Id = Guid.NewGuid(),
BudgetId = budgetId,
SharedWithEmail = req.Email,
SharedWithUserId = knownUser?.Id,
IsPending = knownUser is null,
Permission = req.Permission,
CreatedAt = DateTimeOffset.UtcNow,
};
db.BudgetShares.Add(share);
await db.SaveChangesAsync();
return Ok(new ShareDto(share.Id, share.SharedWithUserId, share.SharedWithEmail, share.Permission, share.IsPending, share.CreatedAt));
}
[HttpPut("{shareId:guid}")]
public async Task<IActionResult> Update(Guid budgetId, Guid shareId, [FromBody] UpdateShareRequest req)
{
if (!await authz.IsOwnerAsync(budgetId, UserId)) return Forbid();
var share = await db.BudgetShares.FirstOrDefaultAsync(s => s.Id == shareId && s.BudgetId == budgetId);
if (share is null) return NotFound();
share.Permission = req.Permission;
await db.SaveChangesAsync();
return Ok(new ShareDto(share.Id, share.SharedWithUserId, share.SharedWithEmail, share.Permission, share.IsPending, share.CreatedAt));
}
[HttpDelete("{shareId:guid}")]
public async Task<IActionResult> Revoke(Guid budgetId, Guid shareId)
{
if (!await authz.IsOwnerAsync(budgetId, UserId)) return Forbid();
var share = await db.BudgetShares.FirstOrDefaultAsync(s => s.Id == shareId && s.BudgetId == budgetId);
if (share is null) return NotFound();
db.BudgetShares.Remove(share);
await db.SaveChangesAsync();
return NoContent();
}
}
+7
View File
@@ -0,0 +1,7 @@
namespace Budget.Api.DTOs;
public record BudgetDto(Guid Id, string Name, string OwnerUserId, decimal EffectiveTaxRate, DateTimeOffset CreatedAt, DateTimeOffset UpdatedAt);
public record CreateBudgetRequest(string Name);
public record UpdateBudgetRequest(string Name);
+9
View File
@@ -0,0 +1,9 @@
using Budget.Api.Models;
namespace Budget.Api.DTOs;
public record ShareDto(Guid Id, string? SharedWithUserId, string SharedWithEmail, SharePermission Permission, bool IsPending, DateTimeOffset CreatedAt);
public record CreateShareRequest(string Email, SharePermission Permission);
public record UpdateShareRequest(SharePermission Permission);
+1
View File
@@ -29,6 +29,7 @@ builder.Services.AddAuthentication(JwtBearerDefaults.AuthenticationScheme)
});
builder.Services.AddAuthorization();
builder.Services.AddScoped<Budget.Api.Services.BudgetAuthorizationService>();
builder.Services.AddControllers();
var app = builder.Build();
@@ -0,0 +1,49 @@
using Budget.Api.Data;
using Budget.Api.Models;
using Microsoft.EntityFrameworkCore;
namespace Budget.Api.Services;
public enum BudgetAccess { None, View, Edit, Owner }
public class BudgetAuthorizationService(AppDbContext db)
{
public async Task<BudgetAccess> GetAccessAsync(Guid budgetId, string userId)
{
var budget = await db.Budgets
.AsNoTracking()
.FirstOrDefaultAsync(b => b.Id == budgetId);
if (budget is null) return BudgetAccess.None;
if (budget.OwnerUserId == userId) return BudgetAccess.Owner;
var share = await db.BudgetShares
.AsNoTracking()
.FirstOrDefaultAsync(s => s.BudgetId == budgetId && s.SharedWithUserId == userId && !s.IsPending);
return share?.Permission switch
{
SharePermission.Edit => BudgetAccess.Edit,
SharePermission.View => BudgetAccess.View,
_ => BudgetAccess.None,
};
}
public async Task<bool> CanReadAsync(Guid budgetId, string userId)
{
var access = await GetAccessAsync(budgetId, userId);
return access != BudgetAccess.None;
}
public async Task<bool> CanWriteAsync(Guid budgetId, string userId)
{
var access = await GetAccessAsync(budgetId, userId);
return access is BudgetAccess.Edit or BudgetAccess.Owner;
}
public async Task<bool> IsOwnerAsync(Guid budgetId, string userId)
{
var access = await GetAccessAsync(budgetId, userId);
return access == BudgetAccess.Owner;
}
}